Fix SH lightmap coefficients for direct lights with packing #103203
+44
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudolph-B
force-pushed
the
Issue-102300-WithPacking
branch
from
650d93f to
8a78d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102300
This PR changes the SH coefficients used for encoding direct light sources. This requires that the L1 packing method also should be adjusted since it is tightly coupled to the SH coefficients.
L1 packing requires that the L1 coefficients are scaled between 0 and 1. This PR achieves this with a sigmoid function. Specifically the logistics function.
Since the new SH coefficients effectively have no average component (
L0 = 0) significant packing artifacts can be seen as only L1 coefficients are packed. I have made some attempts to alleviate this issue but they are still quite prominent.