Fix Node selection when navigating Tree with Arrow keys
#86218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSofox
changed the title
Tree with Arrow keysNode selection when navigating Tree with Arrow keys
AThousandShips
changed the title
Node selection when navigating Tree with Arrow keysNode selection when navigating Tree with Arrow keys
TheSofox
force-pushed
the
arrow-key-scene-tree-nav
branch
from
560696c to
f894eb1
Compare
KoBeWi
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
select_single_item() looks more expensive than what was done previously, but I tested with a very big scene and it's not noticeable.
Also using that method might change what signals are emitted in different selection modes, but this could be desirable (and maybe fix other existing issues).
|
Thanks! |
aaronfranke
reviewed
Jun 10, 2024
| selected_item = prev; | ||
| emit_signal(SNAME("cell_selected")); | ||
|
|
||
| select_single_item(prev, get_root(), selected_col); |
There was a problem hiding this comment.
Why is select_single_item used for SELECT_MULTI?
There was a problem hiding this comment.
Arrow key overrides it. It's exactly what happens in other systems, such as in Windows file explorer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12544
Arrow keys change actual selection (not just cursor) when navigating
TreeandSceneTreeDock.