Remove editor pseudolocalization debug feature #93554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Jun 24, 2024
Mickeon
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
In my opinion the editor can feel lacking in debug utilities for contributors that are as easy to access as Editor Settings are. However, given the niche nature of this setting and likelihood of shooting users in the foot, it's better to not have it at all, or at least have it in its own "Debug" section.
EDIT: The setting IS in fact documented, you have to remove it on the XML file too.
We've seen multiple users enable it by mistake and get utterly confused, reporting as a bug that the interface text is garbled. On the other hand we haven't really seen much use of the feature by editor UI developers, so we can likely simply remove it. If there's a need eventually, we can re-add it as a command line option (which is also better than an editor setting as one would typically want to toggle it during development).
akien-mga
force-pushed
the
remove-editor-pseudolocalization
branch
from
796c8db to
f11e8d0
Compare
Mickeon
approved these changes
Jun 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen multiple users enable it by mistake and get utterly confused, reporting as a bug that the interface text is garbled, or not managing to get back to the settings to toggle it off:
On the other hand we haven't really seen much use of the feature by editor UI developers, so we can likely simply remove it.
If there's a need eventually, we can re-add it as a command line option (which is also better than an editor setting as one would typically want to toggle it during development).