Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Physics Interpolation - Fix Transform2D::interpolate_with() #93851

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Jul 2, 2024

Ports the interpolate_with() routine from 4.x which works correctly with skew.

Fixes #93586.

Notes

  • Looks like Transform2D::interpolate_with() has been bugged for 6 years.
  • This doesn't show up that much in 3.x, because there (as yet) isn't a specific property for skew, so few use it.
  • Also ports set_skew(), get_skew() and the constructor with skew (not bound though, we can discuss binding for 3.7 if desired).

Ports the `interpolate_with()` routine from 4.x which works correctly with skew.
@lawnjelly lawnjelly added this to the 3.6 milestone Jul 2, 2024
@lawnjelly lawnjelly marked this pull request as ready for review July 2, 2024 06:58
@lawnjelly lawnjelly requested a review from a team as a code owner July 2, 2024 06:58
@lawnjelly lawnjelly merged commit c2a43cb into godotengine:3.x Jul 2, 2024
14 checks passed
@lawnjelly
Copy link
Member Author

Thanks!

@lawnjelly lawnjelly deleted the fti_fix_interpolate_with_2D branch July 2, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants