Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment updates for gdb.Builder #2513

Merged
merged 4 commits into from
Mar 28, 2023
Merged

comment updates for gdb.Builder #2513

merged 4 commits into from
Mar 28, 2023

Conversation

org-org-org
Copy link
Contributor

getBuilder creates and returns a cloned WhereBuilder of current WhereBuilder if safe is true,
or else it returns the current WhereBuilder.
But it seems that getBuilder directly returns b.Clone()

@houseme houseme requested a review from gqcn March 11, 2023 02:40
@gqcn
Copy link
Member

gqcn commented Mar 13, 2023

@org-org-org The CI unit testing cases failed. You may need add associated unit testing case to verify your updates.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (1cd1449) 78.62% compared to head (3d43f36) 78.60%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
- Coverage   78.62%   78.60%   -0.03%     
==========================================
  Files         630      630              
  Lines       51318    51389      +71     
==========================================
+ Hits        40349    40394      +45     
- Misses       8984     9007      +23     
- Partials     1985     1988       +3     
Flag Coverage Δ
go-1.15-386 78.63% <ø> (-0.02%) ⬇️
go-1.15-amd64 78.63% <ø> (-0.02%) ⬇️
go-1.16-386 78.63% <ø> (-0.02%) ⬇️
go-1.16-amd64 78.59% <ø> (-0.05%) ⬇️
go-1.17-386 78.64% <ø> (-0.02%) ⬇️
go-1.17-amd64 78.63% <ø> (-0.01%) ⬇️
go-1.18-386 78.55% <ø> (-0.04%) ⬇️
go-1.18-amd64 78.55% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_model_builder.go 97.29% <ø> (ø)

... and 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn changed the title fix: getBuilder comment updates for gdb.Builder Mar 28, 2023
@gqcn gqcn merged commit 67e6772 into gogf:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants