Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support last_affected #700

Closed
oliverchang opened this issue Sep 14, 2022 · 1 comment · Fixed by #1442
Closed

support last_affected #700

oliverchang opened this issue Sep 14, 2022 · 1 comment · Fixed by #1442
Assignees
@oliverchang
Labels
enhancement New feature or request infra infrastructure bugs/FRs

Comments

@oliverchang
Copy link
Collaborator

We've been putting this off since no producers have been using this yet, but GitHub will be doing this soon so we need to add support for it: github/advisory-database#470
@oliverchang oliverchang added enhancement New feature or request infra infrastructure bugs/FRs labels Sep 14, 2022
oliverchang added a commit that referenced this issue Sep 14, 2022
@oliverchang
Support last_affected events for versions.
358056d 
Supporting git commits is still a TODO.

Also clean up some remaining code that handled old/removed fields in the
OSV schema.

Part of #700.
@oliverchang oliverchang mentioned this issue Sep 14, 2022
Merged
@oliverchang oliverchang self-assigned this Sep 16, 2022
oliverchang added a commit that referenced this issue Sep 19, 2022
@oliverchang
Support last_affected events for versions. (#702)
8240fb9 
Supporting git commits is still a TODO.

Also clean up some remaining code that handled old/removed fields in the
OSV schema.

Part of #700.
@oliverchang
Copy link
Collaborator Author

Remaining work: support last_affected for git ranges.

@oliverchang oliverchang mentioned this issue Jul 5, 2023
Merged
andrewpollock added a commit that referenced this issue Aug 30, 2023
@andrewpollock @oliverchang
Add version enumeration for last_affected (#1442)
3501048 
I'd appreciate a thorough review of this:

a) I'm not sure how accurate my docstrings are, because I've basically
tried to reverse engineer my understanding of the code to write them
b) the code changed has no test coverage, and I'd appreciate some
assistance in changing that situation, but I'm having a hard time
understanding how the current tests work...

Fixes #700.

---------

Co-authored-by: Oliver Chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverchang oliverchang

Labels
enhancement New feature or request infra infrastructure bugs/FRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version enumeration for last_affected andrewpollock/osv.dev
1 participant
@oliverchang