Skip to content

Commit

Permalink
Avoid overwriting '__module__' of messages from shared modules. (#5364)
Browse files Browse the repository at this point in the history
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
  • Loading branch information
tseaver authored May 22, 2018
1 parent a8b3d9b commit 8371b09
Showing 1 changed file with 34 additions and 22 deletions.
56 changes: 34 additions & 22 deletions packages/google-cloud-tasks/google/cloud/tasks_v2beta2/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,7 @@
from __future__ import absolute_import
import sys

from google.api_core.protobuf_helpers import get_messages

from google.api import http_pb2
from google.cloud.tasks_v2beta2.proto import cloudtasks_pb2
from google.cloud.tasks_v2beta2.proto import queue_pb2
from google.cloud.tasks_v2beta2.proto import target_pb2
from google.cloud.tasks_v2beta2.proto import task_pb2
from google.iam.v1 import iam_policy_pb2
from google.iam.v1 import policy_pb2
from google.protobuf import any_pb2
Expand All @@ -32,23 +26,41 @@
from google.protobuf import timestamp_pb2
from google.rpc import status_pb2

from google.api_core.protobuf_helpers import get_messages
from google.cloud.tasks_v2beta2.proto import cloudtasks_pb2
from google.cloud.tasks_v2beta2.proto import queue_pb2
from google.cloud.tasks_v2beta2.proto import target_pb2
from google.cloud.tasks_v2beta2.proto import task_pb2


_shared_modules = [
http_pb2,
iam_policy_pb2,
policy_pb2,
any_pb2,
descriptor_pb2,
duration_pb2,
empty_pb2,
field_mask_pb2,
timestamp_pb2,
status_pb2,
]

_local_modules = [
cloudtasks_pb2,
queue_pb2,
target_pb2,
task_pb2,
]

names = []
for module in (
http_pb2,
cloudtasks_pb2,
queue_pb2,
target_pb2,
task_pb2,
iam_policy_pb2,
policy_pb2,
any_pb2,
descriptor_pb2,
duration_pb2,
empty_pb2,
field_mask_pb2,
timestamp_pb2,
status_pb2,
):

for module in _shared_modules:
for name, message in get_messages(module).items():
setattr(sys.modules[__name__], name, message)
names.append(name)

for module in _local_modules:
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.tasks_v2beta2.types'
setattr(sys.modules[__name__], name, message)
Expand Down

0 comments on commit 8371b09

Please sign in to comment.