Skip to content

Commit

Permalink
Avoid overwriting '__module__' of messages from shared modules. (#5364)
Browse files Browse the repository at this point in the history
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
  • Loading branch information
tseaver authored May 22, 2018
1 parent 8c2aaa3 commit e630dd5
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 19 deletions.
27 changes: 20 additions & 7 deletions packages/google-cloud-language/google/cloud/language_v1/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,30 @@
from __future__ import absolute_import
import sys

from google.api_core.protobuf_helpers import get_messages

from google.api import http_pb2
from google.cloud.language_v1.proto import language_service_pb2
from google.protobuf import descriptor_pb2

from google.api_core.protobuf_helpers import get_messages
from google.cloud.language_v1.proto import language_service_pb2


_shared_modules = [
http_pb2,
descriptor_pb2,
]

_local_modules = [
language_service_pb2,
]

names = []
for module in (
http_pb2,
language_service_pb2,
descriptor_pb2, ):

for module in _shared_modules:
for name, message in get_messages(module).items():
setattr(sys.modules[__name__], name, message)
names.append(name)

for module in _local_modules:
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.language_v1.types'
setattr(sys.modules[__name__], name, message)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,40 @@
from __future__ import absolute_import
import sys

from google.api_core.protobuf_helpers import get_messages

from google.api import http_pb2
from google.cloud.language_v1beta2.proto import language_service_pb2
from google.longrunning import operations_pb2
from google.protobuf import any_pb2
from google.protobuf import descriptor_pb2
from google.protobuf import empty_pb2
from google.protobuf import timestamp_pb2
from google.rpc import status_pb2

from google.api_core.protobuf_helpers import get_messages
from google.cloud.language_v1beta2.proto import language_service_pb2


_shared_modules = [
http_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
]

_local_modules = [
language_service_pb2,
]

names = []
for module in (
http_pb2,
language_service_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
empty_pb2,
timestamp_pb2,
status_pb2, ):

for module in _shared_modules:
for name, message in get_messages(module).items():
setattr(sys.modules[__name__], name, message)
names.append(name)

for module in _local_modules:
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.language_v1beta2.types'
setattr(sys.modules[__name__], name, message)
Expand Down

0 comments on commit e630dd5

Please sign in to comment.