Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-firestore tests not included with pypi release #6380

Closed
costrouc opened this issue Nov 2, 2018 · 1 comment
Closed

google-cloud-firestore tests not included with pypi release #6380

costrouc opened this issue Nov 2, 2018 · 1 comment
Assignees
@tseaver
Labels
api: firestore Issues related to the Firestore API. packaging priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@costrouc
Copy link

costrouc commented Nov 2, 2018

Most of the releases of google-cloud-* include the tests with the pypi relases. For some reason they were not included for this package. These tests are needed to verify the installation of python packages in nixpkgs.
@tseaver tseaver added packaging api: firestore Issues related to the Firestore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 2, 2018
@tseaver tseaver self-assigned this Nov 2, 2018
tseaver added a commit that referenced this issue Nov 2, 2018
@tseaver
Firestore: fix path of tests-to-include in MANIFEST.in
7a20b52 
Closes #6380
@tseaver tseaver mentioned this issue Nov 2, 2018
Merged
@tseaver
Copy link
Contributor

tseaver commented Nov 2, 2018

@costrouc Thanks for the report!

@costrouc costrouc changed the title google-cloud-firestore tests not included with pypi relase google-cloud-firestore tests not included with pypi release Nov 2, 2018
@costrouc costrouc closed this as completed Nov 2, 2018
tseaver added a commit that referenced this issue Nov 5, 2018
@tseaver
Firestore: fix path of tests-to-include in MANIFEST.in (#6381)
499b279 
Closes #6380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the Firestore API. packaging priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @costrouc