Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Query's cursor-related methods must not allow transforms #6704

Closed
tseaver opened this issue Nov 29, 2018 · 1 comment
Closed

Firestore: Query's cursor-related methods must not allow transforms #6704

tseaver opened this issue Nov 29, 2018 · 1 comment
Assignees
@tseaver
Labels
api: clouddebugger Issues related to the Cloud Debugger API. api: firestore Issues related to the Firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@tseaver
Copy link
Contributor

tseaver commented Nov 29, 2018 •
edited
Loading

Similar to #6699.

The following conformance tests assert that start_at/start_after/end_before/end_at should raise an exception when passed one of DELETE_FIELD, SERVER_TIMESTAMP, ArrayRemove, or ArrayUnion:

  • query-arrayremove-cursor.textproto
  • query-arrayunion-cursor.textproto
  • query-del-cursor.textproto
  • query-st-cursor.textproto
@tseaver tseaver added priority: p2 Moderately-important priority. Fix may not be included in next release. api: firestore Issues related to the Firestore API. api: clouddebugger Issues related to the Cloud Debugger API. labels Nov 29, 2018
@tseaver tseaver self-assigned this Nov 29, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Nov 29, 2018

We can check this and raise inside _normalize_cursor (added in #6697).

@tseaver tseaver mentioned this issue Nov 29, 2018
Merged
tseaver added a commit that referenced this issue Nov 29, 2018
@tseaver
Prevent use of transforms as cursor values. (#6706)
8a4b07a 
Closes #6704.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: clouddebugger Issues related to the Cloud Debugger API. api: firestore Issues related to the Firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tseaver