Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore integer simple fields #4858

Closed
wants to merge 1 commit into from
Closed

Firestore integer simple fields #4858

wants to merge 1 commit into from

Conversation

chemelnucfin
Copy link
Contributor

Closes #4320
Diff base is #4851

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2018
@theacodes
Copy link
Contributor

Is the diffbase necessary?

@chemelnucfin
Copy link
Contributor Author

not necessary, but create_if_missing should be removed anyway.

@theacodes
Copy link
Contributor

If it can be done without it, please do. You can graft your commit onto master by using git rebase -i master and dropping the unrelated commits.

@chemelnucfin chemelnucfin force-pushed the firestore_integer_simple_fields branch from e0a5f19 to 2e72c7e Compare February 8, 2018 18:33
@chemelnucfin
Copy link
Contributor Author

that was bad, wait a minute

@chemelnucfin chemelnucfin force-pushed the firestore_integer_simple_fields branch from 2e72c7e to 640a9e7 Compare February 8, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chemelnucfin @theacodes @googlebot