Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: block calling 'DocumentRef.get()' with a single string. #6270

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Firestore: block calling 'DocumentRef.get()' with a single string. #6270

merged 1 commit into from
Oct 18, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 18, 2018

Closes #6203.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Oct 18, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2018
chrisrossi
chrisrossi approved these changes Oct 18, 2018
View reviewed changes
Copy link

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 65eec54 into googleapis:master Oct 18, 2018
@tseaver tseaver deleted the 6203-firestore-documentref_get_no_string branch October 18, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @chrisrossi @googlebot