-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datastore: propagate empty arrays in entity values #6285
Conversation
@crwilcox Can you add a system test which exercises your change and verify that the empty list value is preserved in a round-trip? Something like: # Inside 'tests/system/test_system.py', 'TestDatastoreSave'
def test_w_empty_list(self):
entity = self._get_post(id_or_name=(name or key_id))
del entity['tags'][:]
Config.CLIENT.put(entity)
fetched = Config.CLIENT.get(entity.key)
self.assertEqual(entity, fetched) |
@tseaver, sure. I had a unit test so was previously confused by the ask. Let me add to system though. |
Unrelated firestore failure: will be fixed ASAP via #6320. |
I don't know what to do about the shouldn't-even-have-run WSS test failure: it borked trying to download a docker image. |
@tseaver I don't believe these are related failures. Still I am going to rerun the tests. |
@crwilcox Those failures clearly can't be related to this PR: it would be better if they didn't even run at all. That doesn't help for the WSS failure, as it borked before it could even check that |
Fixes #6284.