Firestore: fix delete conformance #6559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
do not merge
googlebot
added
the
cla: yes
6 tasks
Performs depth-first walk of document, yielding (field_path, value) tuples. Special cases handling for empty dict values.
Captures state like that currently returned by '_helpers.process_server_timestamps', but in a clearer, more general way. Rebuilding 'pbs_for_*' atop this foundation to follow.
Use the shiny new 'ExtractDocumentTransforms' instead of 'process_server_timestamps'.
Use the shiny new 'ExtractDocumentTransforms' instead of 'process_server_timestamps'.
Use it in 'pbs_for_create' and 'pbs_for_set_no_merge'.
Use it in 'pbs_for_create' and 'pbs_for_set_no_merge'.
Use it in 'pbs_for_create' and 'pbs_for_set_no_merge'.
Prep for future transforms.
Removes cycle, need to pass client instance / class to 'pbs_for_update'.
In support of 'pbs_for_update'.
In support of 'pbs_for_update'. Raise if expansion of dotted paths results in a conflict.
…rue. FBO tests/unit/testdata/update-badchar.textproto.
It is only relevant for update, which will grow its own extractor.
Factors out construction of the document iterator so that the update extractor can pass 'expand_dots'.
Use it in 'pbs_for_update'.
tseaver
removed
the
do not merge
tseaver
changed the title
|
@crwilcox This PR is now ready for review: all 'set-del-' and 'update-del-' conformance tests are now passing. |
tseaver
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #6533
This is a checkpoint commit. Further work to refactor 'pbs_for_set_with_merge' and 'pbs_for_update' to follow.