Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: 'Query.select([])' implies '__name__'. #6735

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Firestore: 'Query.select([])' implies '__name__'. #6735

merged 1 commit into from
Nov 30, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 30, 2018

Per the query-select-empty.textproto conformance test.

Closes #6734.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Nov 30, 2018
@tseaver tseaver requested a review from crwilcox as a code owner November 30, 2018 17:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2018
@tseaver tseaver merged commit cd143fb into googleapis:master Nov 30, 2018
@tseaver tseaver deleted the 6734-firestore-query-empty_select_implies_name branch November 30, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @crwilcox @googlebot