Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: implement listen conformance #6934

Closed
wants to merge 3,215 commits into from
Closed

Firestore: implement listen conformance #6934

wants to merge 3,215 commits into from

Conversation

mcdonc
Copy link
Contributor

@mcdonc mcdonc commented Dec 17, 2018

Closes #6533

tseaver and others added 30 commits November 7, 2018 14:09
@tseaver
Fix client_info bug, update docstrings via synth. (#6442)
b532a33 
Remove now-spurious replacements from synth.

Fix newly-generated raw HTML junk in docstrings.

Closes #6411.
@dhermes
Implementing GeoPtProperty in ndb. (#6432)
6ae7747 
Using `GeoPoint` from `google-cloud-datastore`.
@tseaver
Harden teardown in system tests. (#6444)
77ef8a4 
Closes #6443.
NDB: Async context (#6429)
5c56e7d 
Establish an async context for managing the current event loop for asynchronous communication with the datastore backend.
@tseaver
Override client classmethod factories inherited from GAPIC. (#6453)
be5a93e 
The '_gapic.add_methods' decorator doesn't quite get them right, so
blacklist them from it and create them locally.

Closes #5903.
@dhermes
Implementing JsonProperty in ndb. (#6447)
7f99171
@dhermes
Implementing DateTimePropery in ndb. (#6448)
639d3a6
@dhermes
Implementing DateProperty and TimeProperty in ndb. (#6452)
0a32a0d
@alixhami @tseaver
Update Dataproc docs URL (#6455)
2dce877
@tseaver
Add 'mock' to unit test dependencies for autogen libs. (#6402)
1896dff 
In anticipation of landing
googleapis/gapic-generator#2407.
Implement get_event_loop. (#6456)
41977e7 
Implement `get_event_loop`.
@yoshi-automation @tseaver
Add 'result_end_time', docstring changes via synth. (#6462)
0dbae1e
@yoshi-automation @tseaver
Docstring changes, 'account' -> 'workspace', via synth. (#6461)
357ce5b
@crwilcox
label some spanner system tests (#6466)
bbd652f
@tseaver
Spanner: rationalize 'all_types' round-trip systest (#6379)
cc25e02 
* Expand 'all_types' table to include arrays of all types.

Use a separate 'pkey' column for the key, to make clear how null integer
values are normally used.

* Remove redundant query param bindings tests using 'all_types' table.

Add tableless tests for float bindings with transfinite values.

Add tableless tests for queries returning explicit transfinite values.

* Refactor round-trip test, 'all_types' data to make feature coverage clearar.
@sumit-ql @tseaver
Fix anonymous usage when run with Bigtable emulator (#6385)
f99bec0 
Closes #6287.
@sduskis
Release bigtable 0.31.1 (#6378)
b475597 
* Release 0.31.1

* Addressing CHANGLONG as per comments

* Applying ` to CHANGLOG

* Update CHANGELOG.md

* Add changes landed this week.

* Update bigtable/CHANGELOG.md

Co-Authored-By: sduskis <[email protected]>
@crwilcox
remove hyphen from named extra in api_core (#6468)
c4778af
@crwilcox
Release api_core 1.5.2 (#6471)
86e986d 
* Release 1.5.2
@crwilcox
Release 1.6.0 (#6469)
405365d
@crwilcox
Release 1.6.1 (#6472)
7e99098
@yoshi-automation @tseaver
Docstring changes via synth. (#6473)
2e3d720
@crwilcox
Firestore: Add Watch Support (#6191)
f9d29c5 
Firestore watch
@tseaver
Import stdlib ABCs from 'collections.abc' rather than 'collections'. (#…
93f4e7e 
…6451)

On Python 2.7, fall back to 'collections'.

Closes #6450.
@crwilcox
Update synth.py yaml location (#6480)
be963cf
@crwilcox
Release 0.35.0 (#6485)
962bcd0
@crwilcox
Synth Cloud scheduler (#6482)
74cea82
@RohanTalip @tseaver
Add support for 'array_contains' query operator. (#6481)
616db21
@dhermes
Implementing KeyProperty in ndb. (#6457)
f4f4d4d
@dhermes
Implementing BlobKeyProperty in ndb. (#6445)
5a9ce6e
tseaver and others added 17 commits December 13, 2018 18:02
@tseaver
Emphasize that returned futures may differ from stdlib futures. (#6875)
53149d5 
Closes #6201.
@tseaver
Docs/fixit: normalize docs for 'page_size' / 'max_results' / 'page_to…
05f90b4 
…ken' (#6842)
@mcdonc
one failure unearthed by making better assertions
e27b9e6
@tseaver
Logging: allow setting name, args on default handler (post-blacken) (#…
350a6d5 
…6828)

- Expose 'stream' argument to handler constructors.

  Defaults to 'None', passed to stdlib's 'logging.StreamHandler'.

- Expose 'name' argument to 'ContainerEngineHandler'.

* Add '**kw' to 'Client.{get_default_handler,setup_logging}'.

  Plumb them through to the underlying handler constructor.

Closes #6206.
@charles-salmon @tseaver
Ensure that ManagedZone:exists() does not misreport True result. (#…
857a0cc 
…6884)

Closes #5818.
@crwilcox
Document Python 2 deprecation (#6910)
8d3d3cd
@crwilcox
Skip signing tests for insufficient credentials (#6917)
3c43f59 
* Skip signing tests for insufficient credentials
@mcdonc
fix merge conflicts with master
38260f0
@mcdonc
blacken
5216ddd
@mcdonc
better info about which snapshot/change we are dealing with
1b879e7
@crwilcox
Include grpc config in manifest (#6928)
de7467f
@crwilcox
Release spanner 1.7.1 (#6929)
9f207ec 
* Release 1.7.1
NDB: Start in on ndb.client.Client (#6876)
d616af8 
NDB: Start implementation of ndb.client.Client.
@sorced-jim @tseaver
Show use of 'batch.begin()' in docstring example. (#6932)
1776c60
@sangramql @tseaver
Add snippets for table operations. (#6484)
0fa42c4
@mcdonc
fix bug in _reset_docs which put snapshot objects instead of document…
70a1329 
… paths into change_map, which was causing listen conformance tests to fail
@mcdonc
Merge remote-tracking branch 'upstream/master' into 6533-implement-li…
4660080 
…sten-conformance
@mcdonc mcdonc requested a review from crwilcox as a code owner December 17, 2018 20:14
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 17, 2018
@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Dec 17, 2018
@tseaver tseaver changed the title implement listen conformance Firestore: implement listen conformance Dec 17, 2018
@mcdonc
Copy link
Contributor Author

mcdonc commented Dec 17, 2018

I made a hash out of my forked repo by attempting to change my email address to avoid the CLA issue. I'll delete my clone, make another clone, and apply the patch squashed and open a new PR.

@mcdonc mcdonc closed this Dec 17, 2018
@mcdonc
Copy link
Contributor Author

mcdonc commented Dec 17, 2018

Superseded by #6935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@alixhami alixhami Awaiting requested review from alixhami

@dhermes dhermes Awaiting requested review from dhermes

@theacodes theacodes Awaiting requested review from theacodes

@tseaver tseaver Awaiting requested review from tseaver

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.