Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: rename 'Query.get' -> 'stream'. #7284

Merged
merged 3 commits into from
Feb 5, 2019
Merged

Firestore: rename 'Query.get' -> 'stream'. #7284

merged 3 commits into from
Feb 5, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 4, 2019

Leave Query.get as a deprecated alias for Query.stream.

Closes #6558.

@tseaver
Rename 'Query.get' -> 'stream'.
73f178c 
Leave 'Query.get' as a deprecated alias for 'Query.stream'.

Closes #6558.
@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Feb 4, 2019
@tseaver tseaver requested a review from crwilcox as a code owner February 4, 2019 20:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2019
@tseaver tseaver merged commit 1e075fd into googleapis:master Feb 5, 2019
@tseaver tseaver deleted the 6558-firestore-rename_query_get_to_stream branch February 5, 2019 21:20
@petervandenabeele
Copy link

I posted a Merge Request to apply this in the python-docs-samples repo:
GoogleCloudPlatform/python-docs-samples#2240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Firestore] Query.get returns incorrect type
4 participants
@tseaver @petervandenabeele @crwilcox @googlebot