Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parent path for watch on queries. #7752

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Use parent path for watch on queries. #7752

merged 2 commits into from
Apr 23, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 18, 2019

Avoids hard-coding the root document, to enable queries on nested
collections.

Closes #7515.
Supersedes #7613.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Apr 18, 2019
@tseaver tseaver requested a review from crwilcox April 18, 2019 21:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2019
tseaver added 2 commits April 23, 2019 14:16
Avoids hard-coding the root document, to enable queries on nested
collections.

Closes #7515.
Supersedes #7613.
@tseaver tseaver merged commit 11c854d into googleapis:master Apr 23, 2019
@tseaver tseaver deleted the 7515-firestore-watch-nested_collections branch April 23, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore: Collection.on_snapshot does not work correctly on nested collections
2 participants