Firestore: Add support for using snapshot cursors in collection group queries. #8810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
IlyaFaer
commented
Jul 30, 2019
tseaver
changed the title
tseaver
suggested changes
Jul 30, 2019
| @@ -257,7 +257,7 @@ def collection_group(self, collection_id): | |||
| ) | |||
|
|
|||
| collection = self.collection(collection_id) | |||
| return query.Query(collection, all_descendants=True) | |||
| return query.Query(collection, all_descendants=True, is_group=True) | |||
There was a problem hiding this comment.
all_descendants already implies a collection group query. We shouldn't need is_group.
There was a problem hiding this comment.
I had a guess, but wasn't 100% sure about all_descendants. I propose to rephrase comment in Query:
all_descendants (Optional[bool]):
When false, selects only collections that are immediate children
of the `parent` specified in the containing `RunQueryRequest`.
When true, selects all descendant collections.
In collection_group() comment we can see tip about last segments of collection's path:
Every collection or subcollection with this ID as the last segment of its
path will be included.
So, I think, query's comment should be alike collection_group's one, 'cause first time I treated it as building down-tree from the specified particular collection
IlyaFaer
force-pushed
the
firestore_group_collection
branch
from
01f4da1 to
3fedc31
Compare
Add helper Add arg to understand, when we're in group Add requested changes Nox Delete argument
IlyaFaer
force-pushed
the
firestore_group_collection
branch
from
50b5292 to
7ab91ba
Compare
AVaksman
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Superseded by #8882. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #8633
I'd propose something like that, though the idea of using snapshot after
collection_group()seems wrong to me. Ascollection_group()includes all collections, which last segment is equal with given collection id, snapshot will be used for different collections, and as exception says it shouldn't be