fix(deps): Require proto-plus >=1.20.5 (#593)

* fix(deps): Require proto-plus >=1.20.5 In proto-plus 1.20.5, the protobuf dependency is pinned to <4.0.0dev Fix #592
googleapis · May 27, 2022 · 2281290 · 2281290
1 parent 843c278
commit 2281290
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/google/cloud/firestore_v1/_helpers.py b/google/cloud/firestore_v1/_helpers.py
@@ -1209,7 +1209,7 @@ def deserialize_bundle(
             bundle_element: BundleElement = BundleElement.from_json(json.dumps(data))  # type: ignore
         except AttributeError as e:
             # Some bad serialization formats cannot be universally deserialized.
-            if e.args[0] == "'dict' object has no attribute 'find'":
+            if e.args[0] == "'dict' object has no attribute 'find'":  # pragma: NO COVER
                 raise ValueError(
                     "Invalid serialization of datetimes. "
                     "Cannot deserialize Bundles created from the NodeJS SDK."

diff --git a/setup.py b/setup.py
@@ -33,7 +33,7 @@
     # Until this issue is closed
     # https://github.com/googleapis/google-cloud-python/issues/10566
     "google-cloud-core >= 1.4.1, <3.0.0dev",
-    "proto-plus >= 1.10.0",
+    "proto-plus >= 1.20.5, <2.0.0dev",
 ]
 extras = {}
 

diff --git a/testing/constraints-3.6.txt b/testing/constraints-3.6.txt
@@ -7,5 +7,5 @@
 # Then this file should have foo==1.14.0
 google-api-core==1.31.5
 google-cloud-core==1.4.1
-proto-plus==1.10.0
-protobuf==3.12.0  # transitive from `google-api-core`
+proto-plus==1.20.5
+protobuf==3.19.0  # transitive from `google-api-core`