Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Require proto-plus >=1.20.5 #593

Merged
merged 5 commits into from
May 27, 2022
Merged

fix(deps): Require proto-plus >=1.20.5 #593

merged 5 commits into from
May 27, 2022

Conversation

Mariatta
Copy link
Contributor

In proto-plus 1.20.5, the protobuf dependency is pinned to <4.0.0dev

Fix #592

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

In proto-plus 1.20.5, the protobuf dependency is pinned to <4.0.0dev

Fix #592
@Mariatta Mariatta requested review from a team as code owners May 26, 2022 23:10
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels May 26, 2022
@Mariatta Mariatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@Mariatta Mariatta merged commit 2281290 into main May 27, 2022
@Mariatta Mariatta deleted the Mariatta-patch-1 branch May 27, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increment no longer working on AWS
3 participants