Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expect 'DocumentSnapshot.__hash__' to expect 'DatetimeWithNanosecons' #392

Closed
wants to merge 3 commits into from

Conversation

Arushi201296
Copy link

Fixes #391 🦕

@Arushi201296 Arushi201296 requested a review from a team July 14, 2021 07:45
@Arushi201296 Arushi201296 requested a review from a team as a code owner July 14, 2021 07:45
@google-cla
Copy link

google-cla bot commented Jul 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Jul 14, 2021
@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 14, 2021
@google-cla
Copy link

google-cla bot commented Jul 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 14, 2021
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2021
@tseaver tseaver changed the title [Bug Fix][Issue-391] Modify __hash__ method of DocumentSnapshot fix: expect 'DocumentSnapshot.__hash__' to expect 'DatetimeWithNanosecons' Jul 14, 2021
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the patch! The PR needs to make corresponding changes to the unit test(s) for __hash__, found in tests/unit/v1/test_base_document.py.

You can run the tests locally with nox: install it via pip install nox and then run nox -s unit-3.8.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 16, 2021
@tseaver
Copy link
Contributor

tseaver commented Jul 16, 2021

Tagged as do not merge pending resolution of the discussion in #398.

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@crwilcox
Copy link
Contributor

crwilcox commented Sep 9, 2021

Note that there are current test failures to address
image

@tseaver
Copy link
Contributor

tseaver commented Oct 4, 2021

@Arushi201296 I've added the needed test in #467, and so I'm closing this PR. Again, thanks for the report and the patch!

@tseaver tseaver closed this Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentSnapshots cannot be stored in a set, unlike DocumentReference
5 participants