-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expect 'DocumentSnapshot.__hash__' to expect 'DatetimeWithNanosecons' #392
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
23c10be
to
dd9e9c9
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
…oper commit message conventions. Sign CLA.
0dd6f5f
to
c2d3195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the patch! The PR needs to make corresponding changes to the unit test(s) for __hash__
, found in tests/unit/v1/test_base_document.py
.
You can run the tests locally with nox
: install it via pip install nox
and then run nox -s unit-3.8
.
Tagged as |
@Arushi201296 I've added the needed test in #467, and so I'm closing this PR. Again, thanks for the report and the patch! |
Fixes #391 🦕