Refactor FilterManager into SharedFilterChain #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
force-pushed
the
filter-manager-update
branch
from
32114bc to
0997cf2
Compare
XAMPPRocky
requested review from
luna-duclos,
rezvaneh and
bombsimon
as code owners
XAMPPRocky
force-pushed
the
filter-manager-update
branch
3 times, most recently
from
af76178 to
416fc91
Compare
markmandel
approved these changes
Mar 9, 2022
| } | ||
| } | ||
|
|
||
| impl TryFrom<&[FilterConfig]> for FilterChain { |
XAMPPRocky
force-pushed
the
filter-manager-update
branch
from
416fc91 to
6e705da
Compare
|
Build Succeeded 🥳 Build Id: 81e22ae3-e856-445a-8787-553b8d9bcf27 To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
FilterManagerintoSharedFilterChain, which instead of using message passing, usesArcSwapto provide a updatable handle to a filter chain. This simplifies a lot of the communication infrastructure as we can just passSharedFilterChaindirectly around instead, update it as needed, and it will be updated on subsequent loads. This also makes it easy to inspect the current state of the filter chain.