-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace serde_yaml with serde_json internally #518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This surely looks way more convenient, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just need to run cargo fmt
and fix the cargo clippy
lints, and it should be good to go.
I had ran them before, can you see what error says? |
|
Build Succeeded 🥳 Build Id: 3a8b1bcd-c679-464a-bb54-c17ed18004c4 To build this version:
|
We replaced
serde_yaml
withserde_json
to simplify writing tests and conversion to protobufWhich issue(s) this PR fixes:
#507