Docker image entrypoint is now /quilkin
#607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh and
vallfors
as code owners
markmandel
force-pushed
the
image/entrypoint
branch
3 times, most recently
from
9229bce to
cfb13a2
Compare
* Changed the entrypoint to /quilkin * Fixed cloudbuild.yaml tests. * Updates to agones integration tests * Updated container documentation * Update Xonotic example, including converting the simple sidecar example to command line arguments. Closes googleforgames#583
markmandel
force-pushed
the
image/entrypoint
branch
from
cfb13a2 to
36e06e4
Compare
|
Build Succeeded 🥳 Build Id: 99c7d307-1c76-46e4-8fb9-8e30f0e4eb43 The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
approved these changes
Sep 28, 2022
XAMPPRocky
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Changed the entrypoint to /quilkin * Fixed cloudbuild.yaml tests. * Updates to agones integration tests * Updated container documentation * Update Xonotic example, including converting the simple sidecar example to command line arguments. Closes #583
XAMPPRocky
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Changed the entrypoint to /quilkin * Fixed cloudbuild.yaml tests. * Updates to agones integration tests * Updated container documentation * Update Xonotic example, including converting the simple sidecar example to command line arguments. Closes #583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This makes life easier for running Quilkin in different modes.
Which issue(s) this PR fixes:
Closes #583
Special notes for your reviewer: