Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo update + flake fixes #930

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

markmandel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Did a full cargo update since rustls has a security issue, but ran into a couple of flaky tests that seem persistent, particularly on Cloud Build - so attempting to do both together.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Did a full `cargo update` since rustls has a security issue, but
ran into a couple of flaky tests that seem persistent, particularly
on Cloud Build - so attempting to do both together.
@markmandel markmandel added area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 19, 2024
@github-actions github-actions bot added size/m and removed size/l labels Apr 19, 2024
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 5a0eaf5c-bfcd-4030-a5f7-67cbb5e7ce2b

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/930/head:pr_930 && git checkout pr_930
cargo build

@XAMPPRocky XAMPPRocky enabled auto-merge (squash) April 23, 2024 09:59
@XAMPPRocky XAMPPRocky merged commit d5ba7fd into googleforgames:main Apr 23, 2024
9 checks passed
@markmandel markmandel deleted the deps/updates branch May 3, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants