Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep a list of middleware resolvers #16

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Keep a list of middleware resolvers #16

merged 1 commit into from
Nov 25, 2018

Conversation

patrys
Copy link
Contributor

@patrys patrys commented Nov 19, 2018

Fixes #15 by unrolling the generator into a list.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.746% when pulling 4d03e85 on patrys:patch-1 into f6b078b on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.746% when pulling 4d03e85 on patrys:patch-1 into f6b078b on graphql-python:master.

@Cito
Copy link
Member

Cito commented Nov 19, 2018 •
edited
Loading

Thanks a lot. We also need to add a regression to tests/execution/test_middleware.py that is failing without this fix. If you like, you can add one, otherwise I will do it when I will look into this later this week.

@Cito Cito merged commit 6a9814d into graphql-python:master Nov 25, 2018
Cito added a commit that referenced this pull request Nov 25, 2018
@Cito
Add regression test for #16
f4e9f07
@patrys patrys deleted the patch-1 branch November 25, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrys @coveralls @Cito