Use identity instead of hash for caching subfields in collect_subfields #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed computing
__hash__
on each cache access is quite expensive, and not what the JS implementation does - they are caching subfield nodes based on argument identity.This PR is based on #55 for the benchmarks, but it can work separately.
Results of
pytest --enable-benchmark -k benchmark
before and after the change:this change also shaved 1/3 of the time from the benchmark mentioned in #54.