Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for middleware #7

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Added support for middleware #7

merged 1 commit into from
Sep 15, 2018

Conversation

syrusakbary
Copy link
Member

Added support for middleware

@syrusakbary syrusakbary requested a review from Cito September 6, 2018 17:40
Cito
Cito reviewed Sep 15, 2018
View reviewed changes
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll merge it and then fix the failing checks. Regarding style changes, see #6.

@Cito Cito merged commit a311b86 into master Sep 15, 2018
@Cito
Copy link
Member

Cito commented Sep 15, 2018 •
edited
Loading

@syrusakbary Can I remove the middlewares = MiddlewareManager alias? I guess it had been added for backward compatibility, but in GraphQL-core-next we should get rid of all deprecated stuff.

Also, ist either ways of passing Middleware (function or object with resolve method) considered deprecated? Then we could remove support for that as well. Or do you want to continue to support both ways?

@Cito Cito deleted the middleware branch September 18, 2018 11:42
@Cito Cito mentioned this pull request Mar 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Cito left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syrusakbary @Cito