BREAKING: remove sorting by name from printSchema

graphql · Jan 23, 2020 · 0912c06 · 0912c06
1 parent bf39198
commit 0912c06
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 57 deletions.
diff --git a/src/utilities/schemaPrinter.js b/src/utilities/schemaPrinter.js
@@ -86,15 +86,7 @@ function printFilteredSchema(
 ): string {
   const directives = schema.getDirectives().filter(directiveFilter);
   const typeMap = schema.getTypeMap();
-  const types = objectValues(typeMap)
-    .sort((type1, type2) => {
-      if (isMutationType(schema, type1)) return -1;
-      if (isQueryType(schema, type1)) return -1;
-      if (isSubscriptionType(schema, type1)) return -1;
-
-      return type1.name.localeCompare(type2.name);
-    })
-    .filter(typeFilter);
+  const types = objectValues(typeMap).filter(typeFilter);
 
   return (
     [printSchemaDefinition(schema)]

diff --git a/src/utilities/typeComparators.js b/src/utilities/typeComparators.js
@@ -120,51 +120,3 @@ export function doTypesOverlap(
   // Otherwise the types do not overlap.
   return false;
 }
-
-/**
- * Checks if type is query
- *
- * @internal
- */
-export function isQueryType(schema: GraphQLSchema, type: GraphQLCompositeType) {
-  const schemaType = schema.getQueryType();
-  if (schemaType) {
-    return schemaType.name === type.name;
-  }
-
-  return false;
-}
-
-/**
- * Checks if type is mutation
- *
- * @internal
- */
-export function isMutationType(
-  schema: GraphQLSchema,
-  type: GraphQLCompositeType,
-) {
-  const schemaType = schema.getMutationType();
-  if (schemaType) {
-    return schemaType.name === type.name;
-  }
-
-  return false;
-}
-
-/**
- * Checks if type is subscription
- *
- * @internal
- */
-export function isSubscriptionType(
-  schema: GraphQLSchema,
-  type: GraphQLCompositeType,
-) {
-  const schemaType = schema.getSubscriptionType();
-  if (schemaType) {
-    return schemaType.name === type.name;
-  }
-
-  return false;
-}