BREAKING: remove sorting by name from printSchema

graphql · Jan 23, 2020 · 73d8fee · 73d8fee
1 parent f6a4938
commit 73d8fee
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 58 deletions.
diff --git a/src/utilities/schemaPrinter.js b/src/utilities/schemaPrinter.js
@@ -33,9 +33,6 @@ import {
 } from '../type/definition';
 
 import { astFromValue } from '../utilities/astFromValue';
-import { isMutationType } from './typeComparators';
-import { isQueryType } from './typeComparators';
-import { isSubscriptionType } from './typeComparators';
 
 type Options = {|
   /**
@@ -90,13 +87,7 @@ function printFilteredSchema(
   const directives = schema.getDirectives().filter(directiveFilter);
   const typeMap = schema.getTypeMap();
   const types = objectValues(typeMap)
-    .sort((type1, type2) => {
-      if (isMutationType(schema, type1)) return -1;
-      if (isQueryType(schema, type1)) return -1;
-      if (isSubscriptionType(schema, type1)) return -1;
 
-      return type1.name.localeCompare(type2.name);
-    })
     .filter(typeFilter);
 
   return (

diff --git a/src/utilities/typeComparators.js b/src/utilities/typeComparators.js
@@ -119,52 +119,4 @@ export function doTypesOverlap(
 
   // Otherwise the types do not overlap.
   return false;
-}
-
-/**
- * Checks if type is query
- *
- * @internal
- */
-export function isQueryType(schema: GraphQLSchema, type: GraphQLCompositeType) {
-  const schemaType = schema.getQueryType();
-  if (schemaType) {
-    return schemaType.name === type.name;
-  }
-
-  return false;
-}
-
-/**
- * Checks if type is mutation
- *
- * @internal
- */
-export function isMutationType(
-  schema: GraphQLSchema,
-  type: GraphQLCompositeType,
-) {
-  const schemaType = schema.getMutationType();
-  if (schemaType) {
-    return schemaType.name === type.name;
-  }
-
-  return false;
-}
-
-/**
- * Checks if type is subscription
- *
- * @internal
- */
-export function isSubscriptionType(
-  schema: GraphQLSchema,
-  type: GraphQLCompositeType,
-) {
-  const schemaType = schema.getSubscriptionType();
-  if (schemaType) {
-    return schemaType.name === type.name;
-  }
-
-  return false;
-}
+}