ESLint: enable more rules for TS code (#2375)

.eslintrc.yml

@@ -437,12 +437,6 @@ overrides:
       import/no-deprecated: off
       import/no-unresolved: off
       import/export: off
-      no-undef: off
-
-      import/first: off
-      import/order: off
-      import/no-useless-path-segments: off
-      lines-between-class-members: off
 
       # Extension Rules
       # https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin#extension-rules

src/language/printLocation.d.ts

@@ -1,6 +1,6 @@
-import { Location } from '../language/ast';
-import { Source } from '../language/source';
-import { SourceLocation } from '../language/location';
+import { Location } from './ast';
+import { Source } from './source';
+import { SourceLocation } from './location';
 
 /**
  * Render a helpful description of the location in the GraphQL Source document.

src/tsutils/Maybe.d.ts

@@ -1,4 +1,6 @@
 // Conveniently represents flow's "Maybe" type https://flow.org/en/docs/types/maybe/
 type Maybe<T> = null | undefined | T;
 
+// See https://github.com/typescript-eslint/typescript-eslint/issues/131
+// eslint-disable-next-line no-undef
 export default Maybe;

src/type/definition.d.ts

@@ -384,6 +384,7 @@ export class GraphQLObjectType<
   constructor(
     config: Readonly<GraphQLObjectTypeConfig<TSource, TContext, TArgs>>,
   );
+
   getFields(): GraphQLFieldMap<any, TContext, TArgs>;
   getInterfaces(): GraphQLInterfaceType[];
 

src/type/directives.d.ts

@@ -1,8 +1,10 @@
 import Maybe from '../tsutils/Maybe';
-import { GraphQLFieldConfigArgumentMap, GraphQLArgument } from './definition';
+
 import { DirectiveDefinitionNode } from '../language/ast';
 import { DirectiveLocationEnum } from '../language/directiveLocation';
 
+import { GraphQLFieldConfigArgumentMap, GraphQLArgument } from './definition';
+
 /**
  * Test if the given value is a GraphQL directive.
  */

src/utilities/buildClientSchema.d.ts

@@ -1,6 +1,7 @@
-import { IntrospectionQuery } from './getIntrospectionQuery';
 import { GraphQLSchema, GraphQLSchemaValidationOptions } from '../type/schema';
 
+import { IntrospectionQuery } from './getIntrospectionQuery';
+
 interface Options extends GraphQLSchemaValidationOptions {}
 
 /**

src/validation/validate.d.ts

@@ -1,9 +1,14 @@
+import Maybe from '../tsutils/Maybe';
+
 import { GraphQLError } from '../error/GraphQLError';
+
 import { DocumentNode } from '../language/ast';
+
 import { GraphQLSchema } from '../type/schema';
+
 import { TypeInfo } from '../utilities/TypeInfo';
+
 import { ValidationRule, SDLValidationRule } from './ValidationContext';
-import Maybe from '../tsutils/Maybe';
 
 /**
  * Implements the "Validation" section of the spec.