Match exact set of errors in schema validation tests #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
reviewed
Apr 6, 2018
| message: `The type of BadInterface.badField must be Output Type but got: ${Number}.`, | ||
| }, | ||
| { | ||
| message: `Expected GraphQL named type but got: ${Number}.`, |
There was a problem hiding this comment.
This one feels low value and duplicative of the error below it, don't you think?
There was a problem hiding this comment.
@leebyron Agree 👍
However I don't see how validate can distinguish beetween those two cases:
validateSchema(new GraphQLSchema({
queryType: Number,
}));validateSchema(new GraphQLSchema({
queryType: new GraphQLObjectType({
name: 'Foo',
fields: { bar: { type: GraphQLString } },
}),
types: [Number],
}));In the first case Expected GraphQL named type but got: ${Number}. is redundant but in second one it's the only error that would be reported.
Can you suggest how to solve this?
| message: `The type of BadObject.badField(badArg:) must be Input Type but got: ${Number}.`, | ||
| }, | ||
| { | ||
| message: `Expected GraphQL named type but got: ${Number}.`, |
There was a problem hiding this comment.
Another example. This is an opportunity to improve the quality of these errors in the future
| message: `The type of BadInputObject.badField must be Input Type but got: ${Number}.`, | ||
| }, | ||
| { | ||
| message: `Expected GraphQL named type but got: ${Number}.`, |
This was referenced Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leebyron Done