Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more tests to KnownArgumentNames validation rule #2198

Merged

Conversation

Cito
Copy link
Member

@Cito Cito commented Sep 25, 2019

Tests that arguments passed to an argument-less directive are properly reported as an error.

The test suite did not catch that this did not work properly in the Python port, so I added these tests.

Tests that arguments passed to an argument-less directive
are properly reported as an error.
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Sep 25, 2019
@IvanGoncharov IvanGoncharov merged commit 5873fd2 into graphql:master Sep 25, 2019
@IvanGoncharov
Copy link
Member

@Cito Thanks a lot 👍

@Cito Cito deleted the add-test-for-known-argument-names-rule branch September 25, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants