Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isValidNameError: Remove node argument #2424

Merged
merged 1 commit into from
Feb 4, 2020
Merged

isValidNameError: Remove node argument #2424

merged 1 commit into from
Feb 4, 2020

Conversation

IvanGoncharov
Copy link
Member

If you want to bind error to node please use locatedError:

const error = isValidNameError(name);
if (error) {
  someFunction(locatedError(error, node));
}

@IvanGoncharov
isValidNameError: Remove node argument
b7fa302 
If you want to bind error to node please use `locatedError`:
```
const error = isValidNameError(name);
if (error) {
  someFunction(locatedError(error, node));
}
```
@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Feb 4, 2020
@IvanGoncharov IvanGoncharov merged commit d72cd3d into graphql:master Feb 4, 2020
@IvanGoncharov IvanGoncharov deleted the pr_branch branch February 4, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IvanGoncharov