Editorial: move "Path" to it's own section #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
benjie
reviewed
Dec 5, 2024
|
@benjie thanks for the feedback! I have applied your suggestions. |
robrichard
force-pushed
the
robrichard/error-path
branch
from
f9c4359 to
2087016
Compare
benjie
requested changes
Jan 9, 2025
Co-authored-by: Benjie <[email protected]>
benjie
reviewed
Jan 13, 2025
Comment on lines
+243
to
+244
| :: A _path entry_ is an entry within an _error result_ that allows for | ||
| association with a particular field reached during GraphQL execution. |
There was a problem hiding this comment.
To other reviewers: in the stream and defer work, this will be changed to say "within an error result or an incremental payload" (or words to that effect).
benjie
approved these changes
Jan 13, 2025
BoD
approved these changes
Feb 6, 2025
mjmahone
approved these changes
Feb 6, 2025
fotoetienne
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from the
@defer/@streamspec edits (#1110) to minimize the diff there.Since the incremental delivery response format also uses
Path, I removed it from the Errors section and into it's own section.