Add support for healthcheck argument start-interval #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. Have verified that tests are working locally, by running act. |
3 tasks
Comment on lines
+50
to
+56
| case (invalid, intervals, timeouts, startPeriods, startIntervals, retriesD) of | ||
| ((k, v) : _, _, _, _, _, _) -> unexpectedFlag k v | ||
| (_, _ : _ : _, _, _, _, _) -> customError $ DuplicateFlagError "--interval" | ||
| (_, _, _ : _ : _, _, _, _) -> customError $ DuplicateFlagError "--timeout" | ||
| (_, _, _, _ : _ : _, _, _) -> customError $ DuplicateFlagError "--start-period" | ||
| (_, _, _, _, _ : _ : _, _) -> customError $ DuplicateFlagError "--start-interval" | ||
| (_, _, _, _, _, _ : _ : _) -> customError $ DuplicateFlagError "--retries" |
There was a problem hiding this comment.
Mmh Haskell case blocks scale as O(n^2)?! Is there an alternative?
make-github-pseudonymous-again
approved these changes
Jun 13, 2024
|
Hey there 👋 Interested in seeing this being supported by hadolint. Any plan on getting this in ? |
|
Any news here? This was approved, can it be merged please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97