-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Add Vault as a Service External Source #10769
Conversation
@kaxcode , can you point me to a template that's populating pill class name? Trying to get a full picture. Ty! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ty!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My only feedback is that ['vault', 'kubernetes', 'terraform', 'nomad', 'consul', 'aws']
appears to be duplicated in a handful of places (in different orders). This smells like data and it might be useful to export from a single location, if feasible. Thoughts?
@randallmorey I agree. I'm not good at working with js template literal files though. Not sure how we can centralize data in the mock-data directory 😬 |
Understood. I'm not sure either! My suggestion isn't urgent. PR approved! |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/422224. |
✨ Description:
Vault is now using the service external-source flag. Vault has always been supported as an external-source, but hasn't always used the flag.
The
Registered in <external-source>
is the Consul::ExternalSource component.The %pill styling is used by Consul::ExternalSource.
Changes:
Demo Link
📸 Screenshots:
You can now find Vault in...
⚡ Backend Changes:
Vault team added supported in this Vault repo PR
🤡 Updates to mock-api:
Updated mock data for the following endpoints:
/health/service/
/internal/ui/gateway-services-nodes/
/internal/ui/service-topology/
/internal/ui/services
🧪 Testing:
No testing added.