Explicit transport protocols in state errors: TCP or UDP #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #234 , when troubleshooting connectivity issues, end-users routinely get confused that Memberlist ping messages are ICMP packets.
I'm basing my edits on the fact that Memberlist pings were already referred to as
UDP Ping
here:memberlist/state.go
Line 535 in a43ca4a
Anytime there is a mention of
ping
, I've added explicitly whether this is an UDP or TCP segment.