Adding the regular emitting of the memberlist broadcast queue #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quency based on the new config value of QueueCheckInterval.
huikang
approved these changes
Aug 26, 2022
…checkBroadcastQueueDepth since there is only one queue.
rboyer
approved these changes
Aug 29, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation
This implementation follows the pattern that exists in serf for capturing intent queue metrics.
Verification
I verified this change by following the Layer 7 Observability Learn Guide to run prometheus and Grafana and view the metrics in a Grafana Dashboard.
Before
Below you can see that
consul_memberlist_queue_Intent(this has since been renamed toconsul_memberlist_queue_broadcast) is not available as a metric.After
Below you can see that
consul_memberlist_queue_Intent(this has since been renamed toconsul_memberlist_queue_broadcast) is available as a metric and is showing data in the dashboard.