Only verify LDAP upndomain matches kerberos domain if set #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DrDaveD, thank you for working on this! After you opened this PR, we had additional discussion about the approach on #44 . Would you be willing to read that through and incorporate the templating approach discussed? If that seems like too much work, no worries, just let us know so we can plan accordingly. Thanks again! |
|
I followed up in #44. |
tyrannosaurus-becks
approved these changes
May 21, 2020
tyrannosaurus-becks
pushed a commit
that referenced
this pull request
May 21, 2020
tyrannosaurus-becks
added a commit
that referenced
this pull request
May 27, 2020
Co-authored-by: DrDaveD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #44.