Skip to content

Commit

Permalink
Update Oracle DB secrets docs to reflect support for static roles (#8168
Browse files Browse the repository at this point in the history
)

* Fix typos

* Update Oracle DB secrets docs to show support for Static Roles

* Add warning about username case sensitivity

* Remove warning about casing

* Fix typo

Co-Authored-By: Becca Petrin <[email protected]>

Co-authored-by: Becca Petrin <[email protected]>
  • Loading branch information
pcman312 and tyrannosaurus-becks authored Feb 13, 2020
1 parent 9f980ad commit 33a7011
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions plugins/database/mysql/mysql.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ func (m *MySQL) SetCredentials(ctx context.Context, statements dbplugin.Statemen
}

// executePreparedStatmentsWithMap loops through the given templated SQL statements and
// applies the a map to them, interpolating values into the templates,returning
// tthe resulting username and password
// applies the map to them, interpolating values into the templates, returning
// the resulting username and password
func (m *MySQL) executePreparedStatmentsWithMap(ctx context.Context, statements []string, queryMap map[string]string) error {
// Grab the lock
m.Lock()
Expand Down
5 changes: 3 additions & 2 deletions website/pages/docs/secrets/databases/oracle.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ description: |-

Oracle is one of the supported plugins for the database secrets engine. This
plugin generates database credentials dynamically based on configured roles for
the Oracle database.
the Oracle database and also supports [Static
Roles](/docs/secrets/databases/index.html#static-roles).

The Oracle database plugin is not bundled in the core Vault code tree and can be
~> The Oracle database plugin is not bundled in the core Vault code tree and can be
found at its own git repository here:
[hashicorp/vault-plugin-database-oracle](https://github.com/hashicorp/vault-plugin-database-oracle)

Expand Down

0 comments on commit 33a7011

Please sign in to comment.