Skip to content

Commit

Permalink
backport of commit 22a2e74
Browse files Browse the repository at this point in the history
  • Loading branch information
ncabatoff authored Nov 15, 2023
1 parent 814d2df commit 4e62d00
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions changelog/24136.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
sdk: Return error when failure occurs setting up node 0 in NewDockerCluster, instead of ignoring it.
```
2 changes: 1 addition & 1 deletion sdk/helper/testcluster/docker/environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ func (dc *DockerCluster) setupDockerCluster(ctx context.Context, opts *DockerClu
}
if i == 0 {
if err := dc.setupNode0(ctx); err != nil {
return nil
return err
}
} else {
if err := dc.joinNode(ctx, i, 0); err != nil {
Expand Down

0 comments on commit 4e62d00

Please sign in to comment.