backport of commit 7872338

hashicorp · Oct 12, 2023 · 5a22639 · 5a22639
1 parent b97ad27
commit 5a22639
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/changelog/23636.txt b/changelog/23636.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+command/server: Fix bug with sigusr2 where pprof files were not closed correctly
+```
diff --git a/command/server.go b/command/server.go
@@ -1847,8 +1847,10 @@ func (c *ServerCommand) Run(args []string) int {
 					err = pprof.Lookup(dump).WriteTo(pFile, 0)
 					if err != nil {
 						c.logger.Error("error generating pprof data", "name", dump, "error", err)
+						pFile.Close()
 						break
 					}
+					pFile.Close()
 				}
 
 				c.logger.Info(fmt.Sprintf("Wrote pprof files to: %s", dir))