Mask LDAP bindpass while typing #10087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelshaw
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a request to mask the LDAP bindpass field while typing. This field is generated by the
masked-inputcomponent, which uses atextAreahtml element. However, to effectively mask the field while typing we needed to change the element toinputand addtype=password(see screenshot and MDN docs here).Before -with the
textAreaelement- you could enter a multi-line password for bindpass. However, given that bindpass is defined as a password field in the LDAP API docs we felt it safe to go ahead and change this to a single-line input field.There are similar requests for the value field in the KV secret engine. Right now, this component will only show the input field when the name is
bindpassbut if we later determine to add other fields we can add a list of them in themasked-inputjavascript file and pass a computed property to the newmaskWhileTypingproperty.See gif
*You'll notice the browser warning in the gif. I tried a variety of suggestions for preventing this, but ultimately this is a browser setting and not something we can safely prevent when we use
type=password. I tried as suggested here turning the input field to readonly and readonly=false onfocus, but that did not work.