Integrated Storage Cloud Auto-Join #10095
Conversation
| @@ -1116,3 +1151,14 @@ type answerResp struct { | |||
| Peers []raft.Peer `json:"peers"` | |||
| TLSKeyring *raft.TLSKeyring `json:"tls_keyring"` | |||
| } | |||
|
|
|||
| func newDiscover() (*discover.Discover, error) { | |||
There was a problem hiding this comment.
Is this helper still needed now that we're not adding k8s?
There was a problem hiding this comment.
Yeah we can safely remove this 👍
There was a problem hiding this comment.
But on second thought, just in case the go-discover API changes, I figure it's safe to be explicit. So I'm leaning towards keeping this.
|
Oh, except test-go is failing for some reason. Better fix that before merging. |
|
1025 files changed haha, which ones should I care about? |
All the non-vendor ones ;-p |
|
|
||
| leaderInfos := []*raft.LeaderJoinInfo{ | ||
| { | ||
| AutoJoin: "provider=aws region=eu-west-1 tag_key=consul tag_value=tag access_key_id=a secret_access_key=a", |
There was a problem hiding this comment.
Are there a set of params that the user has to specify to use auto join? Like, provider and region make sense, but are there other fields that can be used instead of the fields here that specify, as I understand, an IAM user? If so, would it be helpful to have a list of fields that autoJoin can use to join a cluster?
I might also just have this question because I'm new to the raft library :).
There was a problem hiding this comment.
Good question. It's entirely ambiguous and dependent on the cloud provider and operator infrastructure. See go-discover.
No description provided.