add variable entropy readers to cert gen helpers [VAULT-1179] #10653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgmiller
approved these changes
Jan 5, 2021
sgmiller
requested changes
Jan 6, 2021
sdk/helper/certutil/helpers.go
Outdated
|
|
||
| // GenerateSerialNumberWithEntropy generates a serial number suitable | ||
| // for a certificate with custom entropy. | ||
| func GenerateSerialNumberWithEntropy(randReader io.Reader) (*big.Int, error) { |
There was a problem hiding this comment.
Maybe s/Entropy/RandomSource/
sdk/helper/certutil/helpers.go
Outdated
| // Creates a CSR. This is currently only meant for use when | ||
| // generating an intermediate certificate. | ||
| // CreateCSR creates a CSR with the default rand.Reader to | ||
| // generate a cert/keypair. |
There was a problem hiding this comment.
Don't lose the bit about "This is currently only..."
added 2 commits
January 8, 2021 09:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes hand in hand with hashicorp/vault-plugin-secrets-kmip#95 . It allows for private keys to be used with entropy augmentation if needed.
Moved from:https://github.com/hashicorp/vault-enterprise/pull/1664