MSSQL - Add username customization #10767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/dj4wj9cgo [Deployment for 6bf5fb2 canceled] |
calvn
approved these changes
Feb 4, 2021
plugins/database/mssql/mssql.go
Outdated
| @@ -69,12 +76,37 @@ func (m *MSSQL) Initialize(ctx context.Context, req dbplugin.InitializeRequest) | |||
| if err != nil { | |||
| return dbplugin.InitializeResponse{}, err | |||
| } | |||
|
|
|||
| usernameTemplate := getString(req.Config, "username_template") | |||
There was a problem hiding this comment.
We can use strutil.GetString from your other PR. 🙂
There was a problem hiding this comment.
👍 that was the plan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to customize username generation for dynamic users in MSSQL.
Uses the new field
username_templatewith the go template language.Docs PR will come after all other updates for username customization are complete for this release.
Note: #10766 is vendoring in the template files so this PR is failing the go-mod-vendor check until that PR is merged.