KV search box when no list access to metadata #12626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
changed the title
Monkeychip
commented
Sep 24, 2021
| @@ -147,49 +147,4 @@ module('Acceptance | settings/mount-secret-backend', function(hooks) { | |||
| await settled(); | |||
| assert.dom('[data-test-row-value="Maximum number of versions"]').hasText('Not set'); | |||
| }); | |||
|
|
|||
| test('version 2 with no create to sys/mounts endpoint does not allows mounting of secret engine', async function(assert) { | |||
There was a problem hiding this comment.
this test was killing us. It is covered in other tests so I removed (it was one I created for the KV project).
Monkeychip
commented
Sep 27, 2021
| @@ -391,7 +391,113 @@ module('Acceptance | secrets/secret/create', function(hooks) { | |||
| ); | |||
| }); | |||
|
|
|||
| test('version 2 with restricted policy still allows creation', async function(assert) { | |||
| test('paths are properly encoded', async function(assert) { | |||
There was a problem hiding this comment.
moved all the policy tests together.
Monkeychip
commented
Sep 27, 2021
| await click(`[data-test-auth-backend-link=${backend}]`); | ||
| await settled(); | ||
| // this fails in IE11 on browserstack so going directly to URL | ||
| // let card = document.querySelector('[data-test-search-roles]').childNodes[1]; |
There was a problem hiding this comment.
This was the issue with IE11
arnav28
reviewed
Sep 29, 2021
| .catch(() => { | ||
| // there was an error likely in read metadata. | ||
| // still load the page and handle what you show by filtering for this property | ||
| this.noReadAccess = true; |
There was a problem hiding this comment.
Do we need to check for any particular error code?
There was a problem hiding this comment.
Great question. Let me see if I can get more specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles various permissions issues on the KV custom metadata project.
metadata/endpoint you can now search for a secret. If it doesn't exist or you don't have permissions then you see an error page. We could not catch the error and keep them on the same page because of control groups; they throw an identical error and we need to let it proceed.Screen.Recording.2021-09-24.at.12.52.44.PM.mp4
${backend}/config, the config values (maxVersion, CAS, deleteVersionAfter) do not show.Screen.Recording.2021-09-24.at.12.52.44.PM.mp4
Screen.Recording.2021-09-21.at.12.54.09.PM.mp4