Add Patch KV helper #15587
Merged
Add Patch KV helper #15587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it as part of helper method
VinnyHC
reviewed
May 24, 2022
|
I'm adding the no-changelog label since I plan to tag and release this along with #15305 which already has a changelog entry that should cover this in the release notes (as well as future PRs I'm about to do for other KV helper functions like PutMetadata, etc.) @mladlow Let me know if you think otherwise! |
|
@digivava changelog plan sounds good! |
digivava
commented
May 25, 2022
digivava
commented
May 25, 2022
ccapurso
approved these changes
May 26, 2022
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
* Add Read methods for KVClient * KV write helper * Add changelog * Add Delete method * Use extractVersionMetadata inside extractDataAndVersionMetadata * Return nil, nil for v1 writes * Add test for extracting version metadata * Split kv client into v1 and v2-specific clients * Add ability to set options on Put * Add test for KV helpers * Add custom metadata to top level and allow for getting versions as sorted slice * Update tests * Separate KV v1 and v2 into different files * Add test for GetVersionsAsList, rename Metadata key to VersionMetadata for clarity * Move structs and godoc comments to more appropriate files * Add more tests for extract methods * Rework custom metadata helper to be more consistent with other helpers * Remove KVSecret from custom metadata test now that we don't append to it as part of helper method * Add Patch KV helper * Add godoc comment and use WithOption ourselves in other KVOption functions * Clean up options-handling and resp parsing logic; add more tests * Add constants and more patch tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an addition onto the already-merged KV helpers PR (#15305), to add a helper method to the api package that allows the Patch command. The logic is mostly the same as the CLI. It also provides a new
WithOptionKVOption to allow for providing an arbitrary key-value option (for future-proofing if we don't get around to adding new With* functions when new options are developed).